[PATCH] Improved udivmodsi4 with support for ARMv4

Renato Golin renato.golin at linaro.org
Thu Jan 23 00:27:44 PST 2014


  Hi Joerg,

  Apart form my question below, everything looks fine. How have you tested it? Have you benchmarked it against the previous implementation? I do believe you that it's faster, just wanted to know how much gain we get from it.

  cheers,
  --renato


================
Comment at: udivmodsi4.S:62
@@ +61,3 @@
+	sub	r3, r3, ip
+	/* r1 > r0 implies r3 >= 0. */
+	adr	ip, LOCAL_LABEL(div0block)
----------------
I'd have thought that the code would only get here if r0 >= r1, because of the BCC above.

If r1 > r0, this is a case for quotient0, no?


http://llvm-reviews.chandlerc.com/D2595



More information about the llvm-commits mailing list