[llvm] r199835 - Eliminate inappropriate use of FindProgramByName() from lli

[Nick Lewycky]

On 22 January 2014 13:52, Alp Toker <alp at nuanti.com> wrote:

> Author: alp
> Date: Wed Jan 22 15:52:35 2014
> New Revision: 199835
>
> URL: http://llvm.org/viewvc/llvm-project?rev=199835&view=rev
> Log:
> Eliminate inappropriate use of FindProgramByName() from lli
>
> Modified:
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-a.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-sm-pic-a.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/multi-module-a.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/multi-module-sm-pic-a.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/simpletest-remote.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/stubs-remote.ll
>
> llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-common-symbols-remote.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-data-align-remote.ll
>
> llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-fp-no-external-funcs-remote.ll
>
> llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-global-init-nonzero-remote.ll
>     llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-ptr-reloc-remote.ll
>     llvm/trunk/test/Makefile
>     llvm/trunk/test/lit.cfg
>     llvm/trunk/test/lit.site.cfg.in
>     llvm/trunk/tools/lli/lli.cpp
>
> Modified: llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-a.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-a.ll?rev=199835&r1=199834&r2=199835&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-a.ll
> (original)
> +++ llvm/trunk/test/ExecutionEngine/MCJIT/remote/cross-module-a.ll Wed Jan
> 22 15:52:35 2014
> @@ -1,4 +1,4 @@
> -; RUN: %lli_mcjit -extra-module=%p/Inputs/cross-module-b.ll
> -disable-lazy-compilation=true -remote-mcjit
> -mcjit-remote-process=lli-child-target %s > /dev/null
> +; RUN: %lli_mcjit -extra-module=%p/Inputs/cross-module-b.ll
> -disable-lazy-compilation=true -remote-mcjit
> -mcjit-remote-process=lli-child-target%exeext %s > /dev/null
>

Hi Alp! Thanks for removing FindProgramByName!

One question about this patch. We don't use "clang%exeext" or "lli%exeext",
we use "%clang" or "%lli". I think it would make more sense to create
%lli_child_target and use that as the argument. Does that work?

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140122/7d2addf7/attachment.html>