[llvm] r199831 - Add a testcase for r199430.

Quentin Colombet qcolombet at apple.com
Wed Jan 22 12:30:41 PST 2014


On Jan 22, 2014, at 12:20 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> On 22 January 2014 15:11, Quentin Colombet <qcolombet at apple.com> wrote:
>> Author: qcolombet
>> Date: Wed Jan 22 14:11:50 2014
>> New Revision: 199831
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=199831&view=rev
>> Log:
>> Add a testcase for r199430.
>> 
>> Modified:
>>    llvm/trunk/test/CodeGen/X86/codegen-prepare-cast.ll
>> 
>> Modified: llvm/trunk/test/CodeGen/X86/codegen-prepare-cast.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/codegen-prepare-cast.ll?rev=199831&r1=199830&r2=199831&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/CodeGen/X86/codegen-prepare-cast.ll (original)
>> +++ llvm/trunk/test/CodeGen/X86/codegen-prepare-cast.ll Wed Jan 22 14:11:50 2014
>> @@ -1,5 +1,6 @@
>> ; RUN: llc < %s -march=x86-64
>> ; PR4297
>> +; RUN: opt -S < %s -codegenprepare | FileCheck %s
>> 
> 
> I am confused. Wasn't the idea of r199430 to make it possible to use
> "-mtriple=mytriple" with opt?
r199430 is to make possible to use TargetMachine information into IR passes.
To do that, yes, you have to specify a triple.
Nevertheless, The triple can be specified like for llc on either the command line or the file.
The triple was already in the file, so I didn’t add it on the command.
Sorry if it has confused you.

If you want to see what r199430 does, you can run this test with and without it and you will see that without it, codegenprepare is not doing anything on that test.

Does it help?

Thanks,
-Quentin  

> 
> Cheers,
> Rafael





More information about the llvm-commits mailing list