[PATCH] Fix "llvm-objdump -d -r" to show relocations inline for ELF files

[Rafael Espíndola]

> Comment at: tools/llvm-objdump/llvm-objdump.cpp:392
> @@ +391,3 @@
> +                        i != e; i.increment(ec)) {
> +    if (error(ec)) break;
> +    section_iterator Sec2 = i->getRelocatedSection();
> ----------------
> Rafael Ávila de Espíndola wrote:
>> please use llvm naming style, so EC.
>> clang-format. In particular, break in another line.
>>
> I was copying the style of the adjacent code.  Do you want me to make it inconsistent with the following blocks, or should I send you another change to clean up that code first?

Doing an independent patch just fixing the style of the function first
would be perfect.

> In particular, later code uses the "ec" var.  I could add "EC" alongside it, but that would be weird. :-)  What do you prefer here?

It would be strange, yes. Are you OK with changing the names first and
then rebasing this patch?

Thanks,
Rafael