[PATCH] Add target analysis passes to the codegen pipeline for MCJIT

Juergen Ributzka juergen at apple.com
Tue Jan 21 12:19:02 PST 2014


Hi Yaron,

good point. I checked "LLVMTargetMachine::addPassesToEmitFile/addPassesToEmitMachineCode/addPassesToEmitMC" and sometimes the clients add the analysis passes and sometimes they don’t. I decided to place “AddAnalysesPasses" into “addPassesToGenerateCode” instead, since this code is common to all three methods and removed the redundant calls in the clients. I also modified the C API for “AddAnalysesPasses” in the attached patch.

Cheers,
Juergen


On Jan 21, 2014, at 10:45 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Hi Juergen,
> 
> Should these passes be added also in LLVMTargetMachine::addPassesToEmitFile ?
> 
> Yaron
> 
> 
> 
> 2014/1/21 Juergen Ributzka <juergen at apple.com>
> Hi @ll,
> 
> for some reason we forgot to add the target specific analysis passes to the codgen pipeline of MCJIT. All other tools (llc, etc) use these passes and so should MCJIT.
> 
> This patch adds the missing passes to the codegen pipeline. It also exposes the AddAnalysisPasses method through the C API, because the optimizer passes could also benefit from it.
> 
> Cheers,
> Juergen
> 
> 
> 
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140121/75d0fa4b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-target-analysis-passes-to-the-codegen-pipeline.patch
Type: application/octet-stream
Size: 7445 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140121/75d0fa4b/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140121/75d0fa4b/attachment-0001.html>


More information about the llvm-commits mailing list