[PATCH] Fix VS2012 ID/version check

Amara Emerson amara.emerson at arm.com
Tue Jan 21 08:16:11 PST 2014


Hi,

Currently on Windows the check for Visual Studio 2012 fails to be executed
because of a cmake oddity. As a result, VS2010 can still build LLVM despite
being too old now.

The reason is the STREQUAL comparison of the compiler ID to "MSVC" fails
because MSVC happens to be a variable already defined by cmake. The attached
patch fixes it by using MATCHES instead.

Ok to commit?
Amara
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake-vs2012-check.diff
Type: application/octet-stream
Size: 648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140121/f3b1f107/attachment.obj>


More information about the llvm-commits mailing list