[PATCH] ARM IAS: support .object_arch

Saleem Abdulrasool compnerd at compnerd.org
Mon Jan 20 12:21:57 PST 2014


On Mon, Jan 20, 2014 at 10:59 AM, Renato Golin <renato.golin at linaro.org>wrote:

> On 20 January 2014 16:05, Saleem Abdulrasool <compnerd at compnerd.org>wrote:
>
>> The third test is for the assembly emission, and would not actually test
>> if the object file contains the right value (which the second test does).
>>  So, I dont feel that it is redundant.
>>
>
> I meant 1 and 2 are redundant. They are identical, only for the fact that
> the .arch and .object_arch are swapped, which is not a necessary test.
>

You would think that right?  The reason that test exists is because I
actually managed to get that wrong on the first attempt (and the
object_arch was effectively ignored).  Basically the idea is that the order
in which they are in the input are irrelevant and that if .arch comes after
.object_arch, the .object_arch must still be honoured.


> cheers,
> --renato
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140120/de00e1e5/attachment.html>


More information about the llvm-commits mailing list