[PATCH] ARM IAS: support .movsp

Logan Chien tzuhsiang.chien at gmail.com
Mon Jan 20 07:20:17 PST 2014



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:170
@@ +169,3 @@
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
+
----------------
This line will cause compilation error.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:169
@@ +168,3 @@
+  assert((Reg != ARM::SP && Reg != ARM::PC) &&
+         "the operand of .movsp cannot be either sp or pc");
+  assert(UsedFP && ".setfp must precede .movsp");
----------------
It seems that you have added these assertions to address Renato's comments.  However, I feel this is not necessary.  IMO, the assembler which will assemble the generated assembly will perform such check.  How do you think, Renato?


http://llvm-reviews.chandlerc.com/D2530



More information about the llvm-commits mailing list