[PATCH] Enable SLP-vectorization of intrinsics.

Raul Silvera rsilvera at google.com
Fri Jan 17 14:13:19 PST 2014


Cool, I had not noticed that. Thanks for pointing it out. I'll have a read
and reach out to James.
We should be able to use the same infrastructure for both SLP and Loop
vectorization.


On Fri, Jan 17, 2014 at 1:53 PM, Arnold Schwaighofer <
aschwaighofer at apple.com> wrote:

>
> On Jan 17, 2014, at 1:18 PM, Raul Silvera <rsilvera at google.com> wrote:
>
> > That's what I'm seeing. I can get this code to be exercised if I
> manually change the calls to intrinsics, and that's how I've been testing
> it.
> >
> > My plan is to have two more phases for this work:
> > 1. Mimic the code in the Loop vectorizer so that we vectorize a small
> set of math function calls into vector intrinsics.
> >
> > 2. Develop a configurable mechanism to allow vectorization of arbitrary
> functions, integrated into TargetLibraryInfo. This would be configurable so
> that vectorization would be sensitive to different vector libraries
> available in each platform.
>
> Have you seen the "RFC: enable vectorization of call instructions in the
> loop vectorizer" thread?
>
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140113/201603.html
>
> James Molloy is implementing a TargetLibraryInfo interface for this use
> case - vectorized versions of functions - and teaching the loop vectorizer
> to use it.
>
>
> Thanks,
> Arnold
>
> >
> >
> >
> >
> > On Fri, Jan 17, 2014 at 12:41 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> > ----- Original Message -----
> > > From: "Nadav Rotem" <nrotem at apple.com>
> > > To: "Hal Finkel" <hfinkel at anl.gov>
> > > Cc: reviews+D2535+public+071e8fd9238b048b at llvm-reviews.chandlerc.com,
> chandlerc at gmail.com, llvm-commits at cs.uiuc.edu,
> > > rsilvera at google.com
> > > Sent: Friday, January 17, 2014 2:18:53 PM
> > > Subject: Re: [PATCH] Enable SLP-vectorization of intrinsics.
> > >
> > > I think that we are converting some functions to llvm intrinsics.
> > > Right?
> >
> > Clang produces intrinsics for sqrt (only in fast-math mode), pow and
> fma. I think that's it, and until you get to CodeGen, I don't think we
> normally convert anything else at the LLVM level.
> >
> >  -Hal
> >
> > >
> > > On Jan 17, 2014, at 12:11 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> > >
> > > > ----- Original Message -----
> > > >> From: "Nadav Rotem" <nrotem at apple.com>
> > > >> To: nrotem at apple.com, rsilvera at google.com
> > > >> Cc: chandlerc at gmail.com, llvm-commits at cs.uiuc.edu
> > > >> Sent: Friday, January 17, 2014 2:06:55 PM
> > > >> Subject: Re: [PATCH] Enable SLP-vectorization of intrinsics.
> > > >>
> > > >>
> > > >>  The code looks great.  I was wondering if you had a chance to run
> > > >>  some performance tests on it.  Does it catch anything in the LLVM
> > > >>  test suite?
> > > >
> > > > Why do you expect it to catch anything in the test-suite until we
> > > > get the function calls too (just as we do in the loop vectorizer)?
> > > >
> > > > -Hal
> > > >
> > > >>
> > > >> http://llvm-reviews.chandlerc.com/D2535
> > > >> _______________________________________________
> > > >> llvm-commits mailing list
> > > >> llvm-commits at cs.uiuc.edu
> > > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > > >>
> > > >
> > > > --
> > > > Hal Finkel
> > > > Assistant Computational Scientist
> > > > Leadership Computing Facility
> > > > Argonne National Laboratory
> > >
> > >
> >
> > --
> > Hal Finkel
> > Assistant Computational Scientist
> > Leadership Computing Facility
> > Argonne National Laboratory
> >
> >
> >
> > --
> >  Raúl E. Silvera
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
 Raúl E. Silvera
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140117/685c7fdd/attachment.html>


More information about the llvm-commits mailing list