[lld] r199516 - [Mips] Implement .plt and .got.plt section creation.

Simon Atanasyan simon at atanasyan.com
Fri Jan 17 13:37:30 PST 2014


On Sat, Jan 18, 2014 at 1:31 AM, Rui Ueyama <ruiu at google.com> wrote:
> On Fri, Jan 17, 2014 at 1:18 PM, Simon Atanasyan <simon at atanasyan.com>
> wrote:
>>
>> Author: atanasyan
>> Date: Fri Jan 17 15:18:37 2014
>> New Revision: 199516
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=199516&view=rev
>> Log:
>> [Mips] Implement .plt and .got.plt section creation.

[...]

>> +/// \brief LLD_R_MIPS_HI16
>> +void relocLldHi16(uint8_t *location, uint64_t S) {
>> +  int32_t result = lld::scatterBits<uint32_t>((S + 0x8000) >> 16,
>> 0xffff);
>
>
> If my understanding of scatterBits() is correct, this expression is
> equivalent to a more plain one: ((S + 0x8000) >> 16) & 0xffff.

You are right. I'm going to replace all calls to scatterBits() from
MipsRelocationHandler.cpp.

-- 
Simon Atanasyan



More information about the llvm-commits mailing list