[compiler-rt] r199390 - [asan] Fix a build warning on windows.

[Alexey Samsonov]

asan_activation.cc(56) : warning C4800: 'int' : forcing value to bool
'true' or 'false' (performance warning)

Are we interested in warnings like this in Clang?

On Fri, Jan 17, 2014 at 12:55 AM, David Blaikie <dblaikie at gmail.com> wrote:
> What was the warning? Could Clang have reasonable caught/warned about this?
>
>
> On Thu, Jan 16, 2014 at 6:21 AM, Evgeniy Stepanov
> <eugeni.stepanov at gmail.com> wrote:
>>
>> Author: eugenis
>> Date: Thu Jan 16 08:21:17 2014
>> New Revision: 199390
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=199390&view=rev
>> Log:
>> [asan] Fix a build warning on windows.
>>
>> Modified:
>>     compiler-rt/trunk/lib/asan/asan_activation.cc
>>
>> Modified: compiler-rt/trunk/lib/asan/asan_activation.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_activation.cc?rev=199390&r1=199389&r2=199390&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/lib/asan/asan_activation.cc (original)
>> +++ compiler-rt/trunk/lib/asan/asan_activation.cc Thu Jan 16 08:21:17 2014
>> @@ -22,8 +22,8 @@ namespace __asan {
>>  static struct AsanDeactivatedFlags {
>>    int quarantine_size;
>>    int max_redzone;
>> -  int poison_heap;
>>    int malloc_context_size;
>> +  bool poison_heap;
>>  } asan_deactivated_flags;
>>
>>  static bool asan_is_deactivated;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov, MSK