[PATCH] Prevent repetetive warnings for unrecognized processors and features

Artyom Skrobov Artyom.Skrobov at arm.com
Thu Jan 16 10:00:24 PST 2014


Hello,

Right now, if I run

$ llc -mtriple armv7-arm-none-eabi -mcpu=invalid -mattr=+foo,+bar ~/test.ll

I receive six identical "unrecognized processor" warnings, and two identical
warnings for each unrecognized feature:

'invalid' is not a recognized processor for this target (ignoring processor)
'+foo' is not a recognized feature for this target (ignoring feature)
'+bar' is not a recognized feature for this target (ignoring feature)
'invalid' is not a recognized processor for this target (ignoring processor)
'invalid' is not a recognized processor for this target (ignoring processor)
'+foo' is not a recognized feature for this target (ignoring feature)
'+bar' is not a recognized feature for this target (ignoring feature)
'invalid' is not a recognized processor for this target (ignoring processor)
'invalid' is not a recognized processor for this target (ignoring processor)
'invalid' is not a recognized processor for this target (ignoring processor)

We propose a patch that reduces the code duplication and makes sure each
warning is emitted only once; and besides that, it uses SMDiagnostic::print
so that these warning messages are formatted and coloured up consistently
with the normal warning messages.

OK to commit?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unrecognized.patch
Type: application/octet-stream
Size: 8114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140116/ec9e586f/attachment.obj>


More information about the llvm-commits mailing list