[PATCH] [asan] Implement delayed activation of AddressSanitizer

[Alexander Potapenko]

  LGTM with nits.


================
Comment at: lib/asan/asan_activation.h:21
@@ +20,3 @@
+void AsanActivate();
+} // namespace __asan
+
----------------
2-spaces before the comment here and in other places.

================
Comment at: lib/asan/asan_activation.cc:32
@@ +31,3 @@
+void AsanStartDeactivated() {
+  VReport(1, "Deactivating asan\n");
+  // Save flag values.
----------------
So what about proper naming here? ("ASan" vs. "asan")

================
Comment at: lib/asan/asan_malloc_mac.cc:44
@@ -43,3 +43,3 @@
                              vm_size_t start_size, unsigned zone_flags) {
-  if (!asan_inited) __asan_init();
+  if (!asan_inited) AsanInitFromRtl();
   GET_STACK_TRACE_MALLOC;
----------------
Shall we have a macro for this?


http://llvm-reviews.chandlerc.com/D2553