[llvm] r199217 - AVX-512: optimized scalar compare patterns

[Demikhovsky, Elena]

Fixed.

thanks

-  Elena


-----Original Message-----
From: Duncan P. N. Exon Smith [mailto:dexonsmith at apple.com] 
Sent: Tuesday, January 14, 2014 22:18
To: Demikhovsky, Elena
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r199217 - AVX-512: optimized scalar compare patterns

Hi Elena,

The indentation looks a little strange after your commit in a few places:

On Jan 14, 2014, at 7:10 AM, Elena Demikhovsky <elena.demikhovsky at intel.com> wrote:

> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Jan 14 09:10:08 2014
> @@ -10235,8 +10235,11 @@ SDValue X86TargetLowering::LowerSETCC(SD
>       if (!Invert) return Op0;
> 
>       CCode = X86::GetOppositeBranchCondition(CCode);
> -      return DAG.getNode(X86ISD::SETCC, dl, VT,
> +      SDValue SetCC = DAG.getNode(X86ISD::SETCC, dl, MVT::i8,
>                          DAG.getConstant(CCode, MVT::i8), Op0.getOperand(1));

There,

> @@ -10247,8 +10250,11 @@ SDValue X86TargetLowering::LowerSETCC(SD
> 
>   SDValue EFLAGS = EmitCmp(Op0, Op1, X86CC, DAG);
>   EFLAGS = ConvertCmpIfNecessary(EFLAGS, DAG);
> -  return DAG.getNode(X86ISD::SETCC, dl, VT,
> +  SDValue SetCC = DAG.getNode(X86ISD::SETCC, dl, MVT::i8,
>                       DAG.getConstant(X86CC, MVT::i8), EFLAGS);

there, and

> @@ -17696,10 +17702,11 @@ static SDValue CMPEQCombine(SDNode *N, S
>           // See X86ATTInstPrinter.cpp:printSSECC().
>           unsigned x86cc = (cc0 == X86::COND_E) ? 0 : 4;
>           if (Subtarget->hasAVX512()) {
> -            // SETCC type in AVX-512 is MVT::i1
> -            assert(N->getValueType(0) == MVT::i1 && "Unexpected AND node type");
> -            return DAG.getNode(X86ISD::FSETCC, DL, MVT::i1, CMP00, CMP01,
> +            SDValue FSetCC = DAG.getNode(X86ISD::FSETCC, DL, MVT::i1, CMP00, CMP01,
>                                DAG.getConstant(x86cc, MVT::i8));

there.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.