[PATCH] Move arm assembler constant pools to ARMTargetStreamer class

David Peixotto dpeixott at codeaurora.org
Tue Jan 14 15:41:45 PST 2014


On 1/14/2014 7:30 AM, Renato Golin wrote:
> I think it's a good idea to have an object handling the constant pools,
> that would enable us to merge multiple pools, de-duplicate, etc.

Ok, good I think so too. That was a bit of refactoring when I moved the 
constant pools out of the ARMAsmParser.

> But the new ARMTargetMachOStreamer class being all but the constant pool
> is a bit too much, I think. The fact that the ASM streamer and the
> object streamer are separated is a mess, but we shouldn't add more to it.

I was looking for an object that would be accessible to both inline 
assembly and direct assembly. I thought the ARMTargetStreamer would be a 
resonable place, but there was no implementation for MachO so I had to 
add one. Another option could be to change the ARMTargetStreamer from an 
abstract class and provide default empty definitions for all the 
methods. Then MachO could just use an instance of the ARMTargetStreamer 
for the TargetStreamer implementation.

> I have to say I lost touch with how the streamers are being used in the
> grand scheme of things, but I believe only the asm parser is now using
> that streamer and should move to the one the back-end is actually using.
> Rafael should know more...

Ok, lets get an opinion from Rafael.




More information about the llvm-commits mailing list