[PATCH] Set basic block start as microMIPS

Jack Carter Jack.Carter at imgtec.com
Mon Jan 13 14:09:21 PST 2014


I think I got it. Produce a .ll test for default and various parameters (to grow with time as we support more) and test the .s file. To test the common MipsTargetStreamer method for emitting Eheader flags from defaults and parameters I will take .s test case and dump the .o output through objdump.

I will remove the "hack" routine for elfheader emission.

In terms of this particular patch (Set basic block start as microMIPS), I agree that it goes into the CogeGen/Mips area.

Jack
________________________________________
From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
Sent: Monday, January 13, 2014 1:31 PM
To: Jack Carter
Cc: Zoran Jovanovic; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Set basic block start as microMIPS

On 13 January 2014 12:11, Jack Carter <Jack.Carter at imgtec.com> wrote:
> Ok, with the latest changes of the backend using the MC interface I see it.
>
> I'm assuming you want the "hack" routine to stay in place for default and commandline eheader checking or having both AsmPrinter and AsmParser using the same interface and just having llvm-mc produce the test case good enough?

The hack directives should be replaced by the real mips assembly
syntax, whatever that is. The header was already being constructed by
gas before llvm, so there has to be a way to produce it.

As for this patch, it is changing CodeGen, so it should be checking
the produced assembly. Given that it is using emitMipsHackSTOCG, it
would probably be better to first replace that method with the real
mips assembly syntax.

Cheers,
Rafael





More information about the llvm-commits mailing list