[PATCH] Don't crash generating DWARF debug info for an ObjC property of type void

[Eric Christopher]

Can you put the objective-c code that the testcase is derived from into the
test? Also, to be precise, your patch isn't reinstating anything it's
adding a check where one should have been.

Thanks.

-eric

On Mon Jan 13 2014 at 2:42:44 AM, Scott Talbot <s at chikachow.org> wrote:

> In both 3.4 and HEAD, generating DWARF debug info with an ObjC property of
> type void results in a crash in the compiler due to a failed assertion.
> That assertion was added in r187963, where it replaced a test with an
> early-return if the type was invalid.
> This change restores the previous behaviour, preventing the emission of a
> type node for void ObjC properties.
>
> Scott Talbot (2):
>  Avoid emitting a DWARF type for an ObjC property of type void
>  Test that an ObjC property of type void is accepted
>
> lib/CodeGen/AsmPrinter/DwarfUnit.cpp       |  3 +-
> test/CodeGen/Generic/objc-property-void.ll | 83
> ++++++++++++++++++++++++++++++
> 2 files changed, 85 insertions(+), 1 deletion(-)
> create mode 100644 test/CodeGen/Generic/objc-property-void.ll
>
> -Scott
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140113/1039e6d3/attachment.html>