[PATCH] Don't crash generating DWARF debug info for an ObjC property of type void

Scott Talbot s at chikachow.org
Mon Jan 13 02:40:14 PST 2014


In both 3.4 and HEAD, generating DWARF debug info with an ObjC property of type void results in a crash in the compiler due to a failed assertion.
That assertion was added in r187963, where it replaced a test with an early-return if the type was invalid.
This change restores the previous behaviour, preventing the emission of a type node for void ObjC properties.

Scott Talbot (2):
 Avoid emitting a DWARF type for an ObjC property of type void
 Test that an ObjC property of type void is accepted

lib/CodeGen/AsmPrinter/DwarfUnit.cpp       |  3 +-
test/CodeGen/Generic/objc-property-void.ll | 83 ++++++++++++++++++++++++++++++
2 files changed, 85 insertions(+), 1 deletion(-)
create mode 100644 test/CodeGen/Generic/objc-property-void.ll

-Scott


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-emitting-a-DWARF-type-for-an-ObjC-property-of-.patch
Type: application/octet-stream
Size: 778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140113/b47568bb/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Test-that-an-ObjC-property-of-type-void-is-accepted.patch
Type: application/octet-stream
Size: 9736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140113/b47568bb/attachment-0001.obj>


More information about the llvm-commits mailing list