[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Eric Christopher]

Ah right. Fair enough. For some reason I thought you guys did windows
hosted stuff on occasion. I don't know what made me think that.

-eric

On Fri Jan 10 2014 at 3:34:51 PM, Robinson, Paul <
Paul_Robinson at playstation.sony.com> wrote:

>  We're Windows hosted but not Windows targeted, so didn't seem relevant
> to our stuff.
>
> If "this" was about something else let me know; I haven't been paying
> attention to this thread.
>
> --paulr
>
>
>
> *From:* Eric Christopher [mailto:echristo at gmail.com]
> *Sent:* Friday, January 10, 2014 12:50 PM
> *To:* timurrrr at google.com;
> reviews+D2232+public+3e8da1453c292d84 at llvm-reviews.chandlerc.com;
> rnk at google.com; dblaikie at gmail.com; william.ledoux at gmail.com;
> rafael.espindola at gmail.com; llvm-commits at cs.uiuc.edu; Robinson, Paul
> *Subject:* Re: [PATCH] [prototype] Adding line table debug information to
> LLVM on Windows
>
>
>
> Paul: Is this going to be an issue for you guys? I imagine so, but I'd
> like to verify.
>
>
>
> -eric
>
> On Fri Jan 10 2014 at 5:30:15 AM, Timur Iskhodzhanov <timurrrr at google.com>
> wrote:
>
> As we've discussed on llvm-dev earlier, we'll choose the debug info format
> based on the triple for now (to simplify things) but may add a command line
> option later when needed.
>
> Are you OK if I just add a FIXME before the condition for now?
>
> 09 янв. 2014 г. 18:11 пользователь "Eric Christopher" <echristo at gmail.com>
> написал:
>
>
>
>
>   Looks pretty good, thanks.
>
>   I'd prefer you split out the MC bit when you commit, just because it's
> not necessary as part of this. One other comment below.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
> @@ -195,3 +197,3 @@
>    if (MAI->doesSupportDebugInformation()) {
> -    DD = new DwarfDebug(this, &M);
> -    Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
> +    if (Triple(TM.getTargetTriple()).isOSWindows()) {
> +      Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
> ----------------
> I'm not sure this is the right conditional for this - at the very least it
> should be possible to continue with dwarf information on windows and this
> isn't going to let it. Possibly a command line option?
>
>
> http://llvm-reviews.chandlerc.com/D2232
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140110/b01bdb02/attachment.html>