[PATCH] Must not produce Tag_CPU_arch_profile for pre-ARMv7 cores

Renato Golin renato.golin at linaro.org
Fri Jan 10 04:23:45 PST 2014


Hi Ayrton,

Splitting in two, as Saleem mentioned, looks good to me.

cheers,
--renato


On 9 January 2014 19:12, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:

> Hello,
>
> In the "Addenda to, and Errata in, the ABI for the ARM Architecture"
> (
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ihi0045d/index.
> html), section 2.3.5.2 "The target-related attributes" specifies that
> Tag_CPU_arch_profile must have the default value of 0 when "Architecture
> profile is not applicable (e.g. pre v7, or cross-profile code)". LLVM
> violates the ABI by emitting this build attribute when targeting ARMv6M.
>
> Our proposed patch fixes this, and additionally, it amends
> test/MC/ARM/thumb2-mclass.s to match its apparent original purpose (to test
> the ARMv6M/ARMv7M commonality), and creates a new test case for the
> differences between ARMv6M and ARMv7M (i.e. the availability of basepri,
> basepri_max and faultmask registers)
>
> OK to commit?
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140110/cba8a44d/attachment.html>


More information about the llvm-commits mailing list