[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Eric Christopher]

  Looks pretty good, thanks.

  I'd prefer you split out the MC bit when you commit, just because it's not necessary as part of this. One other comment below.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
@@ -195,3 +197,3 @@
   if (MAI->doesSupportDebugInformation()) {
-    DD = new DwarfDebug(this, &M);
-    Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
+    if (Triple(TM.getTargetTriple()).isOSWindows()) {
+      Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
----------------
I'm not sure this is the right conditional for this - at the very least it should be possible to continue with dwarf information on windows and this isn't going to let it. Possibly a command line option?


http://llvm-reviews.chandlerc.com/D2232