[compiler-rt] r196802 - Revert three patches which were committed without explicit contribution

[Chandler Carruth]

On Tue, Dec 10, 2013 at 6:22 AM, Peter Bergner <bergner at vnet.ibm.com> wrote:

> > Revert three patches which were committed without explicit contribution
> > by their authors.
> >
> > This may break builds where others added code relying on these patches,
> > but please *do not* revert this commit. Instead, we will prepare patches
> > which fix the failures.
> >
> > Reverts the following commits:
> > r168306: "[asan] support x32 mode in the fast stack unwinder. Patch by
> H.J. Lu"
> > r168356: "[asan] more support for powerpc, patch by Peter Bergner"
> > r196489: "[sanitizer] fix the ppc32 build (patch by Jakub Jelinek)"
>
>
> As one of the authors of these patches, what is the rational for reverting
> them?


Sorry for the terrible delays in responding to this thread. Holiday
vacation and travel plans by multiple different people conspired to hold up
my response until this week.

The crux of the problem is that we need have some process for folks to
contribute the patch explicitly to the LLVM project (in addition to
potentially contributing it to the branch of the code in use by GCC). We
hadn't really clarified what that process was, and there wasn't really any
process followed for these patches. That's not cool, as it isn't respectful
to the authors.

I've mailed out a patch to the LLVM developer's policy which should clarify
this. The only thing that would help is for the authors of these three
patches (and the fourth patch I found later) to just email a copy of the
patch to llvm-commits, or if any of you have commit access to directly
commit the patch.

I don't want someone to look back and say "hey, how come this guy just
submitted that other person's code!" Instead I want them to see an explicit
contribution of the code by that person to the project. Typically not a big
deal, but I felt like we didn't do a good job the first time here, so I
want to make it extra clear here that we were respecting your wishes here.
=] That's all.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140109/17ce58dd/attachment.html>