[PATCH] Set basic block start as microMIPS

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 9 10:24:13 PST 2014


On 20 December 2013 17:23, Jack Carter <Jack.Carter at imgtec.com> wrote:
> Zoran,
>
> Patches, compiles, tests and code looks ok.
>
> You may get pushback for not having a .s testcase.
> The intragrated assembler is only tested for .s output. For the ELF object
> testing one is suppose to use llvm-mc.
>
> I know it doesn't make sense in this case, but it is what it is.

It makes perfect sense. Why would there be an object only code path in
here? If the patch changes generated assembly it should FileCheck the
assembly. If the patch adds features to the assembler it should use
llvm-mc.

Cheers,
Rafael



More information about the llvm-commits mailing list