[patch] Simplify the datalayout strings by using the defaults

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Jan 9 05:01:57 PST 2014


Looks good to me as well. Thanks for updating the docs.

> -----Original Message-----
> From: Rafael EspĂ­ndola [mailto:rafael.espindola at gmail.com]
> Sent: 06 January 2014 18:55
> To: Daniel Sanders
> Cc: llvm-commits; Jim Grosbach
> Subject: Re: [patch] Simplify the datalayout strings by using the defaults
> 
> >> By the way, the documentation (at
> http://llvm.org/docs/LangRef.html#data-layout) doesn't say the default
> value of <pref> (in i<size>:<abi>:<pref>). It's reasonable to assume <abi> but
> it ought to say that. Similarly it doesn't say the meaning of <size> (in
> a<size>:<abi>:<pref> and s<size>:<abi>:<pref>) when it is zero or omitted.
> Could you add a sentence or two to explain it?
> >
> > The size is never used. The attached patch updates the documentation
> > to always omit the size of 's' and 'a' and adds an assert to check
> > that they are always 0.
> 
> A rebased patch is attached. What do you think?
> 
> Cheers,
> Rafael




More information about the llvm-commits mailing list