[llvm] r198793 - Add missing definitions of key_type and value_type to DenseSet.

[Matt Arsenault]

DenseSet does have the comment that it's implemented with DenseMap and
should be fixed if it becomes a performance problem.


On Wed, Jan 8, 2014 at 4:59 PM, Owen Anderson <resistor at mac.com> wrote:

>
> On Jan 8, 2014, at 1:52 PM, Chandler Carruth <chandlerc at google.com> wrote:
>
>
> On Wed, Jan 8, 2014 at 4:38 PM, Matt Arsenault <Matthew.Arsenault at amd.com>wrote:
>
>> Add missing definitions of key_type and value_type to DenseSet.
>>
>> This matches std::set and allows using DenseSet with the functions
>> in SetOperations.h
>>
>
> Just keep in mind that DenseSet is unusually expensive. I worry whenever
> people are using DenseSet because it has strange costs associated with it.
>
>
> Sounds like some additional discussion of when DenseSet is appropriate
> could be useful in ProgrammersManual.html !
>
> —Owen
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140108/8387c1fd/attachment.html>