[patch] Drop support for mangling unnamed globals

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Jan 8 12:13:47 PST 2014


HI Chris,

This feature apparently exists to make it easier for frontends to
create auxiliary functions and variables without worrying about their
names. It has quiet a bit of history, I tried to find when it was
introduced, but it is older than the current mangler. It already
existed back when % and @ were one :-)

Given that LLVM will rename a global if the name is already used, it
is easy for a frontend to create auxiliary globals that are already
unique at the llvm level, so the mangler/codegen features seems a bit
redundant.

This is not a critical patch, just a possible cleanup I noticed when
moving the Mangler. It does remove a DenseMap, making the Mangler a
bit lighter.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 31228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140108/13c41f27/attachment.obj>


More information about the llvm-commits mailing list