[patch] Simplify the datalayout strings by using the defaults

Jim Grosbach grosbach at apple.com
Mon Jan 6 12:10:35 PST 2014


On Jan 6, 2014, at 10:55 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

>>> By the way, the documentation (at http://llvm.org/docs/LangRef.html#data-layout) doesn't say the default value of <pref> (in i<size>:<abi>:<pref>). It's reasonable to assume <abi> but it ought to say that. Similarly it doesn't say the meaning of <size> (in a<size>:<abi>:<pref> and s<size>:<abi>:<pref>) when it is zero or omitted. Could you add a sentence or two to explain it?
>> 
>> The size is never used. The attached patch updates the documentation
>> to always omit the size of 's' and 'a' and adds an assert to check
>> that they are always 0.
> 
> A rebased patch is attached. What do you think?

Seems OK to me.

-Jim

> 
> Cheers,
> Rafael
> <t.patch>





More information about the llvm-commits mailing list