XCore target: fix const section handling

Richard Osborne richard at xmos.com
Mon Jan 6 10:34:44 PST 2014


+    if (  (GVar->isConstant() &&
+           UnderlyingGV->isLocalLinkage(GV->getLinkage()))
+       || (GVar->hasSection() &&
+           StringRef(GVar->getSection()).startswith(".cp.")) )

Extra spaces inside ( )?

Looks good to me otherwise (assuming the clang patch is applied first).

On 09/12/13 18:03, Robert Lytton wrote:
> Hi,
>
> Here is a patch for the xcore target
>
>     XCore target: fix const section handling
>
>     Xcore target ABI requires const data that is externally visible
>     to be handled differently if it has C-language linkage rather than
>     C++ language linkage.
>
>     Clang now emits ".cp.rodata" section information.
>
>     All other externally visible constant data will be placed in the 
> DP section.
>
> Robert


-- 
Richard Osborne | XMOS
http://www.xmos.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140106/9e1be4e7/attachment.html>


More information about the llvm-commits mailing list