[PATCH] [PATCH][mips] .abicalls and .set pic0 support

[Rafael Ávila de Espíndola]

  LGTM with just a few comments.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2490
@@ +2489,3 @@
+            "unexpected token in .option pic0 directive");
+      Parser.eatToEndOfStatement();
+    }
----------------
There is a "return true" missing in the error path, no?

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2564
@@ +2563,3 @@
+      // Clear line
+      Parser.eatToEndOfStatement();
+    }
----------------
missing a return true in here, no?

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp:27
@@ -25,3 +26,3 @@
 
-// pin vtable to this file
+// Pin vtable to this file.
 void MipsTargetStreamer::anchor() {}
----------------
It is OK to leave this in, but in the future please just commit independent cleanups like this independently. They qualify for post commit review.


http://llvm-reviews.chandlerc.com/D2446

BRANCH
  master

ARCANIST PROJECT
  llvm