[llvm] r198587 - Remove argument to fix build bot failure.

David Woodhouse dwmw2 at infradead.org
Mon Jan 6 01:46:50 PST 2014


On Mon, 2014-01-06 at 07:19 +0000, David Woodhouse wrote:
> 
> Ah crap, sorry about that. As 2am approached I obviously  didn't do a
> wonderful job of removing the 'Features' argument when I reordered the
> pafches. Although I had actually build tested most intermediate steps, and
> the version of r198586 that's in my own tree *did* remove this stray one -
> although of course it would have been better if r198584 had never added it
> in the first place.

Correction: the stray use of 'Features' was added in r198586 ("Add
OpSize16bit, for instructions which need..."), and you *did* of course
apply my latest version of that. I had mistakenly removed the 'Features'
argument in the *subsequent* patch, rather than eliding it out of the
history completely.

I obviously failed to test that intermediate stage between those two
patches. On the basis that it shouldn't have *changed* anything, I
suppose — although I don't really claim to vouch for my thought process
at 2am.

I have rebased my tree on top of the current LLVM master, and have
actually spent the last hour or so building and testing *every*
intermediate commit this time. Apologies again for the build break.

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140106/65c83d96/attachment.bin>


More information about the llvm-commits mailing list