[PATCH] ARM: move ARMUnwindOp.h into Support

Chandler Carruth chandlerc at google.com
Sun Jan 5 17:53:58 PST 2014


On Sun, Jan 5, 2014 at 6:31 PM, Saleem Abdulrasool <compnerd at compnerd.org>wrote:

>   FWIW, I had the same concerns as you Logan, which is why I sent this out
> for review.  This is following the precedent for this set by the Windows
> x64 unwinding support.  I did briefly look at something like what you were
> thinking and found that I would rather leave that to another time (as it
> would be a lot more work).
>

I'll give my LGTM on the layering here as well. This header file is
strictly defining external format details. It looks very much like ELF.h
and COFF.h in the same directory.

I agree that it would be nice to have a better way to isolate
platform-specific format definitions, but we don't today have such a
mechanism. This seems a reasonable compromise.

One request for you Saleem: could you add citations to the header file much
like COFF.h? Would help others that want to update or check various aspects
of these definitions.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140105/057c6363/attachment.html>


More information about the llvm-commits mailing list