[PATCH v2 02/14] [x86] Add basic support for .code16

[David Woodhouse]

On Sun, 2014-01-05 at 22:31 +0100, Joerg Sonnenberger wrote:
> I don't have a problem with using two flag bits and a encoding of like
> 0 invalid, 1 16bit, 2 32bit, 3 64bit or some other permutation of the
> last three.

And call the bits 'Not64BitMode' and 'Not16BitMode'?

And end up with something like this in X86MCTargetDesc.cpp:

@@ -47,9 +47,9 @@ std::string X86_MC::ParseX86Triple(StringRef TT) {
   Triple TheTriple(TT);
   std::string FS;
   if (TheTriple.getArch() == Triple::x86_64)
-    FS = "+64bit-mode";
+    FS = "-not64bit-mode,+not16bit-mode";
   else
-    FS = "-64bit-mode";
+    FS = "+not64bit-mode,+not16bit-mode";
   return FS;
 }
 
I am not so keen on that. But then, I don't really care that much
either. If the two of you can reach an agreement, I'll do it whichever
way is required to get it merged.

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140105/eb765b79/attachment.bin>