[llvm] r198530 - Mark the 64-bit x86 push/pop instructions as In64BitMode. Mark the corresponding 32-bit versions with the same encodings Not64BitMode. Remove hack from tablegen disassembler table emitter. Fix bad test.

David Woodhouse dwmw2 at infradead.org
Sun Jan 5 03:15:52 PST 2014


On Sun, 2014-01-05 at 01:35 +0000, Craig Topper wrote:
> 
> Mark the 64-bit x86 push/pop instructions as In64BitMode. Mark the
> corresponding 32-bit versions with the same encodings Not64BitMode.
> Remove hack from tablegen disassembler table emitter. Fix bad test.

Lots of shiny new conflicts for my .code16 patch series there :)

Have rebased, retested and pushed it out again to
http://git.infradead.org/users/dwmw2/llvm.git (with a new patch at the
end which attempts to clean up the EncodeInstruction() handling of
optionally-specified features, preemptively addressing what I *expected*
I might get as feedback to the PR18303 fix.)

I may not bother doing so any more, though — if nobody's looking at it
anyway, it may make more sense just to give up and go back to my day job
for now, until/unless someone has time to look at what I've done. When
someone's looked at it for long enough to notice and *tell* me that it
no longer applies cleanly, I can pick it up again.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140105/aad4b994/attachment.bin>


More information about the llvm-commits mailing list