PATCH for PR18000: wrong code at -Os and above on x86_64-linux-gnu

Andrew Trick atrick at apple.com
Fri Jan 3 13:34:48 PST 2014


On Dec 31, 2013, at 10:46 AM, Stepan Dyatkovskiy <STPWORLD at narod.ru> wrote:

> Sorry, sent broken patch file. Reattached.
> -Stepan.
> 
> Stepan Dyatkovskiy wrote:
>> Hello,
>> 
>> The things starts to be wrong, as I assume (thanks to David Wiberg) in
>> ScalarEvolution::getZeroExtendExpr
>> 
>> As I think the entire problem caused by an ancient typo in
>> ScalarEvolution::isImpliedCond that is invoked inside (patch changes
>> only one line).
>> 
>> For people how knows ScalarEvolution enough it would be easy to
>> understand whether it was typo.
>> 
>> I also posted detailed explanations here:
>> http://llvm.org/bugs/show_bug.cgi?id=18000#c16

I think this is the right fix. Thanks for analyzing the bug. I took me a while just to understand what was happening here and prove to myself it was in fact a typo!

-Andy



More information about the llvm-commits mailing list