[PATCH] ARM IAS: refactor unwind context

Saleem Abdulrasool compnerd at compnerd.org
Sun Dec 29 07:52:37 PST 2013



================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8337
@@ -8301,3 +8336,3 @@
   // Check the ordering of unwind directives
-  if (!FnStartLoc.isValid()) {
+  if (!UC.isValid()) {
     Error(L, ".fnstart must precede .fnend directive");
----------------
Logan Chien wrote:
> For example, this condition says !UC.isValid(), but we are only checking .fnstart.
Sure, Ill rename it before submitting.  For what its worth, the reason that I named it isValid is because the idea is that you are checking if the unwind context is valid (e.g. has been created).


http://llvm-reviews.chandlerc.com/D2486



More information about the llvm-commits mailing list