[patch] EXPORTED_SYMBOL_FILE support for cmake

Chandler Carruth chandlerc at google.com
Sat Dec 28 16:31:17 PST 2013


On Sat, Dec 28, 2013 at 6:28 PM, Nico Weber <thakis at chromium.org> wrote:

> Since I won't have access to a windows or linux box until monday, this
> addresses a FIXME and blocks deadstripping for the cmake build, I'll land
> this for post-commit review and hope that the bots will help me sort things
> out. (I tested the non-darwin branches on my os x box by temporarily
> changing the conditionals, they seem to do what they're supposed to do.)
>

SGTM. Sorry for not replying sooner, I sent my only comment in post-commit.
I'm very confident the more interesting thing is sorting out how to make
this work on all the platforms which I see you're doing. Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131228/b5b0fc68/attachment.html>


More information about the llvm-commits mailing list