[PATCH] ARM IAS: improve .eabi_attribute handling

Saleem Abdulrasool compnerd at compnerd.org
Sat Dec 28 14:56:52 PST 2013



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMBuildAttrs.cpp:63
@@ +62,3 @@
+  { ARMBuildAttrs::Virtualization_use, "Tag_Virtualization_use" },
+  { ARMBuildAttrs::MPextension_use_old, "Tag_MPextension_use_old" },
+
----------------
Logan Chien wrote:
> IMO, we should not parse Tag_MPextension_use_old for two reasons: (1) This value is deprecated (2) There is no existing usage of this tag name.
I can drop it from the table, but that does not prevent someone from using the numeric value.  Why should we drop the textual representation in that case?

Im not really opposed to removing it, I would just like to understand why dropping it partially is better than just permitting the compatibility.


http://llvm-reviews.chandlerc.com/D2484



More information about the llvm-commits mailing list