[PATCH] [lsan] Make the report_objects flag more useful.

Kostya Serebryany kcc at google.com
Mon Dec 23 23:33:31 PST 2013


  LGTM with 2 nits


================
Comment at: lib/lsan/lsan_common.cc:376
@@ -375,2 +375,3 @@
     uptr resolution = flags()->resolution;
+    u32 stack_trace_id;
     if (resolution > 0) {
----------------
initialize this, we don't have msan to catch UMRs for us.

================
Comment at: lib/lsan/lsan_common.cc:511
@@ -525,1 +510,3 @@
+  if (i == leaks_.size()) {
   if (leaks_.size() == kMaxLeaksConsidered) return;
+    Leak leak = { next_id_++, /* hit_count */ 1, leaked_size, stack_trace_id,
----------------
indent?


http://llvm-reviews.chandlerc.com/D2459

BRANCH
  feat/lsan/better_report_objects

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list