[PATCH] Fix loop rerolling pass failure with non-consant loop lower

David Peixotto dpeixott at codeaurora.org
Fri Dec 20 17:09:41 PST 2013

Proposed fix for PR18290: http://llvm.org/bugs/show_bug.cgi?id=18290

The loop rerolling pass was failing with an assertion failure from a
failed cast on loops like this:

  void foo(int *A, int *B, int m, int n) {
    for (int i = m; i < n; i+=4) {
      A[i+0] = B[i+0] * 4;
      A[i+1] = B[i+1] * 4;
      A[i+2] = B[i+2] * 4;
      A[i+3] = B[i+3] * 4;

The code was casting the SCEV-expanded code for the new
induction variable to a phi-node. When the loop had a non-constant
lower bound, the SCEV expander would end the code expansion with an
add insted of a phi node and the cast would fail.

It looks like the cast to a phi node was only needed to get the
induction variable value coming from the backedge to compute the end
of loop condition. This patch changes the loop reroller to compare
the induction variable to the number of times the backedge is taken
instead of the iteration count of the loop. In other words, we stop
the loop when the current value of the induction variable ==
IterationCount-1. Previously, the comparison was comparing the
induction variable value from the next iteration == IterationCount.

This problem only seems to occur on 32-bit targets. For some reason,
the loop is not rerolled on 64-bit targets.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-loop-rerolling-pass-failure-with-non-consant-loo.patch
Type: application/octet-stream
Size: 14672 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131220/c492c481/attachment.obj>

More information about the llvm-commits mailing list