[PATCH] [prototype] Adding line table debug information to LLVM on Windows

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Dec 20 12:41:45 PST 2013

On 20 December 2013 15:12, dblaikie at gmail.com <dblaikie at gmail.com> wrote:
> If both of those aren't valid strings in the domain you're using this map
> for, sure. (pedantry: StringRef("", 1) would suffice, since StringRef's
> don't need to be null terminated :))

But that is still a valid string ref.  Using std::map fro now is fine,
but for future reference: It looks like that to implement something
like a DenseMap<StringRef> we need to change the type trait a bit. It
should include an optional isThumbStone and isEmpty and with that we
should be able to use actually invalid StringRefs like StringRef("",
2) and StringRef("", 3).


More information about the llvm-commits mailing list