[PATCH] [prototype] Adding line table debug information to LLVM on Windows

dblaikie at gmail.com dblaikie at gmail.com
Fri Dec 20 12:12:01 PST 2013


If both of those aren't valid strings in the domain you're using this map
for, sure. (pedantry: StringRef("", 1) would suffice, since StringRef's
don't need to be null terminated :))

On Fri Dec 20 2013 at 12:10:12 PM, Timur Iskhodzhanov <timurrrr at google.com>
wrote:

> Or can I use StringRef() as an empty key and StringRef("\0", 1) as a
> tombstone?
>
> 2013/12/21 Timur Iskhodzhanov <timurrrr at google.com>:
> > 2013/12/20 dblaikie at gmail.com <dblaikie at gmail.com>:
> >> If you don't need null values, you could have <null, ""> be the empty
> key
> >> and <"", null> be the tombstone, or something like that.
> >
> > Or I can use an explicit second DenseMap template parameter... will
> > give it a try.
> >
> > Would appreciate if you continue to review the rest of the patch
> > assuming I'll fix this header soon :)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131220/31bcf0c3/attachment.html>


More information about the llvm-commits mailing list