[PATCH] [prototype] Adding line table debug information to LLVM on Windows

Timur Iskhodzhanov timurrrr at google.com
Fri Dec 20 11:50:49 PST 2013



================
Comment at: include/llvm/ADT/DenseMapInfo.h:136
@@ +135,3 @@
+  static inline StringRef getEmptyKey() { return StringRef("emptykey"); }
+  static inline StringRef getTombstoneKey() { return StringRef("tombstone!"); }
+  static unsigned getHashValue(const StringRef &Val) {
----------------
Rafael Ávila de Espíndola wrote:
> This is way too specific to be in this header. "emptykey" and "tombstone!" are valid keys.
Agreed, but not sure how to proceed.

Can you recommend a better way to create a `DenseMap<pair<StringRef, StringRef>, X>` ?


http://llvm-reviews.chandlerc.com/D2232



More information about the llvm-commits mailing list