[PATCH] [prototype] Adding line table debug information to LLVM on Windows

Timur Iskhodzhanov timurrrr at google.com
Fri Dec 20 05:08:45 PST 2013



================
Comment at: test/DebugInfo/COFF/multifile.ll:3
@@ +2,3 @@
+; RUN: llc -mtriple=i686-pc-win32 -filetype=obj -o - -O0 < %s | llvm-readobj -s -sr -codeview-linetables | FileCheck --check-prefix=OBJ32 %s
+; RUN: llc -mtriple=x86_64-pc-win32 -filetype=asm -O0 < %s | FileCheck --check-prefix=X64 %s
+
----------------
oops, forgotten the OBJ64 RUN line

================
Comment at: test/DebugInfo/COFF/asm.ll:1
@@ +1,2 @@
+; RUN: llc -mtriple=i686-pc-win32 -filetype=obj -o - -O0 < %s | llvm-readobj -s -sr -codeview-linetables | FileCheck --check-prefix=OBJ32 %s
+; RUN: llc -mtriple=x86_64-pc-win32 -filetype=obj -o - -O0 < %s | llvm-readobj -s -sr -codeview-linetables | FileCheck --check-prefix=OBJ64 %s
----------------
Rafael Ávila de Espíndola wrote:
> Please check the generated assembly instead of using -filetype=obj.
Do you mean:
a) I shouldn't be using `-filetype=obj` in these tests at all
or
b) I should use at least `-filetype=asm` in each test
or
c) I should use `-filtype=asm` rather than `=obj` in this very test?

Anyways, adding the `=obj` RUN lines and checks to this file...

================
Comment at: test/DebugInfo/COFF/multifile.ll:209
@@ +208,3 @@
+; OBJ64-NEXT:     Filename: D:\two.c
+; OBJ64-NEXT:     +0x0: 2
+; OBJ64-NEXT:   ]
----------------
Typo: should be `+0x9`.


http://llvm-reviews.chandlerc.com/D2232



More information about the llvm-commits mailing list