[patch] Remove the 's' DataLayout specification

Chris Lattner clattner at apple.com
Thu Dec 19 11:15:35 PST 2013

On Dec 17, 2013, at 3:16 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> During the years there have been some attempts at figuring out how to
> align byval arguments. A look at the commit log suggests that they
> were
> * Use the ABI alignment.
> * When that was not sufficient for x86-64, I added the 's'
> specification to DataLayout.
> * When that was not sufficient Evan added the virtual getByValTypeAlignment.
> * When even that was not sufficient, we just got the FE to add the
> alignment to the byval.
> This patch is just a simple cleanup that removes my first attempt at
> fixing the problem. I also added an AArch64 implementation of
> getByValTypeAlignment to make sure this patch is a nop. I also left
> the 's' parsing for backward compatibility.

This is fine with me in principle, assuming it doesn’t change any interesting behavior :-).


More information about the llvm-commits mailing list