[PATCH] [AArch64 NEON] Accept both #0.0 and #0 for comparing with floating point zero in asm parser.
t.p.northover at gmail.com
Wed Dec 18 11:03:03 PST 2013
A nice change overall, but it may be slightly more complicated than necessary:
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:1642
@@ +1641,3 @@
+ APFloat RealVal(APFloat::IEEEdouble, Parser.getTok().getString());
+ if (Negative) RealVal.changeSign();
This asserts on "0x0", which is slightly surprising as a user. But given that the only valid value is 0, couldn't this function be rather simplified anyway? And made to give better diagnostics in the process.
More information about the llvm-commits