[llvm] r197466 - Add -mcpu=z10 to SystemZ tests.

Richard Sandiford rsandifo at linux.vnet.ibm.com
Wed Dec 18 03:32:36 PST 2013

Hi Andrew,

Andrew Trick <atrick at apple.com> writes:
> URL: http://llvm.org/viewvc/llvm-project?rev=197466&view=rev
> Log:
> Add -mcpu=z10 to SystemZ tests.
> Modified:
>     llvm/trunk/test/CodeGen/SystemZ/int-div-01.ll
>     llvm/trunk/test/CodeGen/SystemZ/int-div-03.ll
>     llvm/trunk/test/CodeGen/SystemZ/int-div-04.ll
>     llvm/trunk/test/CodeGen/SystemZ/int-mul-08.ll

I tried winding back to r197465 and it looks like you added these because
on z196 you got:

        ogrk %r2, %r2, %r3      instead of      ogr %r2, %r3
  and   ork %r2, %r2, %r3       instead of      or %r2, %r3

Is that right?  We don't really want to use the three-address forms
(OGRK and ORK) when the two-address form would do.  In these cases
I think the destination and first source are natural ties so we really
should be using OGR and OR for z196 too.

It looks like current trunk (r197599) works again for -mcpu=z196.
Would it be OK to revert this for now?


More information about the llvm-commits mailing list