[PATCH] [lld] Registry model for Readers and Reference Kind strings

[Joey Gouly]

================
Comment at: include/lld/Driver/DarwinInputGraph.h:56
@@ -54,6 +55,3 @@
 
-    if (filePath->endswith(".objtxt"))
-      return ctx.getYAMLReader().parseFile(_buffer, _files);
-
-    (void) (_isWholeArchive);
-    return error_code::success();
+    if (_isWholeArchive) {
+      std::vector<std::unique_ptr<File>> parsedFiles;
----------------
Should this change be included?

================
Comment at: include/lld/ReaderWriter/ELFLinkingContext.h:235
@@ -230,3 +234,3 @@
 protected:
-  ELFLinkingContext(llvm::Triple, std::unique_ptr<TargetHandlerBase>);
+  ELFLinkingContext( llvm::Triple, std::unique_ptr<TargetHandlerBase>);
 
----------------
Randomly inserted whitespace!

================
Comment at: include/lld/ReaderWriter/Reader.h:81
@@ +80,3 @@
+  bool referenceKindToString(Reference::KindNamespace ns, Reference::KindArch a, 
+                             uint16_t value, StringRef &) const;
+  
----------------
I'm wondering if we should use a typedef for Reference::KindValue?

================
Comment at: include/lld/ReaderWriter/YamlContext.h:20
@@ +19,3 @@
+namespace lld {
+  class File;
+  class LinkingContext;
----------------
Indentation looks really weird here.


http://llvm-reviews.chandlerc.com/D2431

BRANCH
  svn

ARCANIST PROJECT
  lld