[PATCH] Change how MachOLinkingContext initializes defaults

Nick Kledzik kledzik at apple.com
Tue Dec 17 18:46:35 PST 2013

On Dec 6, 2013, at 10:38 PM, Joe Ranieri <joe at alacatialabs.com> wrote:
> On Mon, Dec 2, 2013 at 7:12 PM, Nick Kledzik <kledzik at apple.com> wrote:
>> Joe,
>> It is a little odd to have some setXXX() methods be called before initialize() and some after.  I’d rather get rid of:
>>  setOS()
>>  setArch()
>>  setOutputFileType()
>> And instead have just:
>>  configure(HeaderFileType type, OS os, StringRef minOSVersion);
>> which sets those values then does what your initialize() function does.
> Fixed.
> -- Joe Ranieri
> <macholinkingcontext_configure2.diff>

This looks good to me.  

Sorry for the slow response.  I’ve been wrestling with a big patch I just posted for review today.  

I can commit this patch tomorrow.  


More information about the llvm-commits mailing list