[PATCH] AsmParser: add support for .end directive

Saleem Abdulrasool compnerd at compnerd.org
Tue Dec 17 18:29:19 PST 2013

On Tue, Dec 17, 2013 at 9:59 AM, David Peixotto <dpeixott at codeaurora.org>wrote:

> On 12/16/2013 6:11 PM, Saleem Abdulrasool wrote:
>> On Mon, Dec 16, 2013 at 10:24 AM, David Peixotto
>> <dpeixott at codeaurora.org <mailto:dpeixott at codeaurora.org>> wrote:
>>     My main question is how does this directive interact with .include'd
>>     files. If we have .end in a file that is being processed because of
>>     a .include will it stop processing everything, or only that file. I
>>     think gas will stop processing everything, even the original file.
>>     Please add a test case that shows the behavior to expect when
>>     processing a .end directive in a .include file. I think it is ok to
>>     follow what gas does here.
>> Yes, the behaviour would be that.  The includes are handled by the
>> preprocessor, and the lexer would consume the rest of the tokens,
>> behaving as gas does.  I suppose I can add additional tests.
> Ok, sounds good to me. Just to be clear my question was about the .include
> assembler directive rather than a #include processed by the pre-processor.

Bleh, misread that.  Either way, that is still the behaviour.  It will stop
due to the .end in the .include'd file, and not read the rest of the parent
file either.  The additional test will be part of the commit.

Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/1e208550/attachment.html>

More information about the llvm-commits mailing list