[llvm] r197499 - Add some simple COFF files with Z7 debug info

David Blaikie dblaikie at gmail.com
Tue Dec 17 11:58:49 PST 2013


I'd probably revert & commit it along with the dumper changes that
introduce test cases that use these files. Makes it easier to keep track of
why files were introduced, etc. (but this isn't a strict requirement, just
a thought/preference - if you don't remove them I'd at least suggest
following up to this commit with the revision that introduces uses for
these tests)


On Tue, Dec 17, 2013 at 11:55 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> Should I un-commit or it is OK to stick this way?
> 17 дек. 2013 г. 23:39 пользователь "David Blaikie" <dblaikie at gmail.com>
> написал:
>
> An example of this would be dumping support for DWARF type units which I
>> committed in r191234 along with binary examples (generated from GCC in that
>> instance) long before Clang had support for type units.
>>
>>
>> On Tue, Dec 17, 2013 at 11:38 AM, David Blaikie <dblaikie at gmail.com>wrote:
>>
>>> We don't usually checkin test files without test cases. I think Eric was
>>> suggesting committing dumping support along with binary files to test the
>>> dumping support in one go, but separate/prior to the LLVM output support
>>> that would use the dumper to test LLVM.
>>>
>>>
>>> On Tue, Dec 17, 2013 at 6:33 AM, Timur Iskhodzhanov <timurrrr at google.com
>>> > wrote:
>>>
>>>> Author: timurrrr
>>>> Date: Tue Dec 17 08:33:31 2013
>>>> New Revision: 197499
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=197499&view=rev
>>>> Log:
>>>> Add some simple COFF files with Z7 debug info
>>>>
>>>> These will later be used as tests for the dumper part of
>>>> http://llvm-reviews.chandlerc.com/D2232
>>>>
>>>> Added:
>>>>
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-i368
>>>>   (with props)
>>>>
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-x86_64
>>>>   (with props)
>>>>
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-i368
>>>>   (with props)
>>>>
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-x86_64
>>>>   (with props)
>>>>
>>>> Added:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-i368
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-i368?rev=197499&view=auto
>>>>
>>>> ==============================================================================
>>>> Binary file - no diff available.
>>>>
>>>> Propchange:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-i368
>>>>
>>>> ------------------------------------------------------------------------------
>>>>     svn:mime-type = application/octet-stream
>>>>
>>>> Added:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-x86_64
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-x86_64?rev=197499&view=auto
>>>>
>>>> ==============================================================================
>>>> Binary file - no diff available.
>>>>
>>>> Propchange:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifile-linetables.obj.coff-2012-x86_64
>>>>
>>>> ------------------------------------------------------------------------------
>>>>     svn:mime-type = application/octet-stream
>>>>
>>>> Added:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-i368
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-i368?rev=197499&view=auto
>>>>
>>>> ==============================================================================
>>>> Binary file - no diff available.
>>>>
>>>> Propchange:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-i368
>>>>
>>>> ------------------------------------------------------------------------------
>>>>     svn:mime-type = application/octet-stream
>>>>
>>>> Added:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-x86_64
>>>> URL:
>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-x86_64?rev=197499&view=auto
>>>>
>>>> ==============================================================================
>>>> Binary file - no diff available.
>>>>
>>>> Propchange:
>>>> llvm/trunk/test/tools/llvm-readobj/Inputs/multifunction-linetables.obj.coff-2012-x86_64
>>>>
>>>> ------------------------------------------------------------------------------
>>>>     svn:mime-type = application/octet-stream
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/749647fe/attachment.html>


More information about the llvm-commits mailing list